git commit: Use a Maven profile to activate FindBugs 3.0.0 only on Java 8.

Discussion:

Matt Sicker

2014-09-29 14:31:15 UTC

This could use a profile id like jdk8.
---------- Forwarded message ----------
From: <***@apache.org>
Date: 29 September 2014 09:28
Subject: git commit: Use a Maven profile to activate FindBugs 3.0.0 only on
Java 8.
To: ***@logging.apache.org

Repository: logging-log4j2
Updated Branches:
refs/heads/master 1201fa3d6 -> 630aea837

Use a Maven profile to activate FindBugs 3.0.0 only on Java 8.

Project: http://git-wip-us.apache.org/repos/asf/logging-log4j2/repo
Commit:
http://git-wip-us.apache.org/repos/asf/logging-log4j2/commit/630aea83
Tree: http://git-wip-us.apache.org/repos/asf/logging-log4j2/tree/630aea83
Diff: http://git-wip-us.apache.org/repos/asf/logging-log4j2/diff/630aea83

Branch: refs/heads/master
Commit: 630aea83739fed055ccb07f1e50c17f9a7fc0921
Parents: 1201fa3
Author: Gary Gregory <***@gmail.com>
Authored: Mon Sep 29 10:28:47 2014 -0400
Committer: Gary Gregory <***@gmail.com>
Committed: Mon Sep 29 10:28:47 2014 -0400

----------------------------------------------------------------------
pom.xml | 8 ++++++++
1 file changed, 8 insertions(+)
----------------------------------------------------------------------

http://git-wip-us.apache.org/repos/asf/logging-log4j2/blob/630aea83/pom.xml
----------------------------------------------------------------------
diff --git a/pom.xml b/pom.xml
index e710812..a9024cf 100644
--- a/pom.xml
+++ b/pom.xml
@@ -1275,5 +1275,13 @@
</plugins>
</build>
</profile>
+ <profile>
+ <activation>
+ <jdk>[1.8,)</jdk>
+ </activation>
+ <properties>
+ <findbugs.plugin.version>3.0.0</findbugs.plugin.version>
+ </properties>
+ </profile>
</profiles>
</project>

--
Matt Sicker <***@gmail.com>

Gary Gregory

2014-09-29 15:40:11 UTC

Permalink

Post by Matt Sicker
This could use a profile id like jdk8.

But does that mean that you then need to invoke it specifically with the -P
option?

Gary

Post by Matt Sicker
---------- Forwarded message ----------
Date: 29 September 2014 09:28
Subject: git commit: Use a Maven profile to activate FindBugs 3.0.0 only
on Java 8.
Repository: logging-log4j2
refs/heads/master 1201fa3d6 -> 630aea837
Use a Maven profile to activate FindBugs 3.0.0 only on Java 8.
Project: http://git-wip-us.apache.org/repos/asf/logging-log4j2/repo
http://git-wip-us.apache.org/repos/asf/logging-log4j2/commit/630aea83
Tree: http://git-wip-us.apache.org/repos/asf/logging-log4j2/tree/630aea83
Diff: http://git-wip-us.apache.org/repos/asf/logging-log4j2/diff/630aea83
Branch: refs/heads/master
Commit: 630aea83739fed055ccb07f1e50c17f9a7fc0921
Parents: 1201fa3
Authored: Mon Sep 29 10:28:47 2014 -0400
Committed: Mon Sep 29 10:28:47 2014 -0400
----------------------------------------------------------------------
pom.xml | 8 ++++++++
1 file changed, 8 insertions(+)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/logging-log4j2/blob/630aea83/pom.xml
----------------------------------------------------------------------
diff --git a/pom.xml b/pom.xml
index e710812..a9024cf 100644
--- a/pom.xml
+++ b/pom.xml
@@ -1275,5 +1275,13 @@
</plugins>
</build>
</profile>
+ <profile>
+ <activation>
+ <jdk>[1.8,)</jdk>
+ </activation>
+ <properties>
+ <findbugs.plugin.version>3.0.0</findbugs.plugin.version>
+ </properties>
+ </profile>
</profiles>
</project>
--

--
E-Mail: ***@gmail.com | ***@apache.org
Java Persistence with Hibernate, Second Edition
<http://www.manning.com/bauer3/>
JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
Spring Batch in Action <http://www.manning.com/templier/>
Blog: http://garygregory.wordpress.com
Home: http://garygregory.com/
Tweet! http://twitter.com/GaryGregory

Matt Sicker

2014-09-29 21:33:56 UTC

Permalink

Nah, profiles all need an ID regardless. The activation element allows
profiles to be automatically activated.

Post by Gary Gregory

Post by Matt Sicker
This could use a profile id like jdk8.

But does that mean that you then need to invoke it specifically with the
-P option?
Gary

--
Java Persistence with Hibernate, Second Edition
<http://www.manning.com/bauer3/>
JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
Spring Batch in Action <http://www.manning.com/templier/>
Blog: http://garygregory.wordpress.com
Home: http://garygregory.com/
Tweet! http://twitter.com/GaryGregory

--
Matt Sicker <***@gmail.com>