[jira] [Updated] (LOG4J2-867) FlumeAppender: maxDelay not in seconds, but milliseconds

Discussion:

Simon Broeng Jensen (JIRA)

2014-10-03 12:34:33 UTC

[ https://issues.apache.org/jira/browse/LOG4J2-867?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Simon Broeng Jensen updated LOG4J2-867:
---------------------------------------
Summary: FlumeAppender: maxDelay not in seconds, but milliseconds (was: FlumeAppender: maxDelay not in seconds, but miliseconds)

FlumeAppender: maxDelay not in seconds, but milliseconds
--------------------------------------------------------
Key: LOG4J2-867
URL: https://issues.apache.org/jira/browse/LOG4J2-867
Project: Log4j 2
Issue Type: Documentation
Components: Appenders
Affects Versions: 2.0.2
Reporter: Simon Broeng Jensen
Priority: Minor
Hi,
We are using FlumeAppender with Log4j2, version 2.0.2.
The documentation, and javadoc, specifies maxDelay as using seconds, but it's actually used as milliseconds (see FlumePersistentManager).
https://logging.apache.org/log4j/2.x/manual/appenders.html#FlumeAppender

--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Simon Broeng Jensen (JIRA)

2014-10-03 12:34:33 UTC

Permalink

Simon Broeng Jensen created LOG4J2-867:
------------------------------------------

Summary: FlumeAppender: maxDelay not in seconds, but miliseconds
Key: LOG4J2-867
URL: https://issues.apache.org/jira/browse/LOG4J2-867
Project: Log4j 2
Issue Type: Documentation
Components: Appenders
Affects Versions: 2.0.2
Reporter: Simon Broeng Jensen
Priority: Minor

Hi,

We are using FlumeAppender with Log4j2, version 2.0.2.

The documentation, and javadoc, specifies maxDelay as using seconds, but it's actually used as milliseconds (see FlumePersistentManager).

We would suggest updating the javadoc, and documentation at:
https://logging.apache.org/log4j/2.x/manual/appenders.html#FlumeAppender

--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Gary Gregory (JIRA)

2014-10-03 14:01:33 UTC

Permalink

[ https://issues.apache.org/jira/browse/LOG4J2-867?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14157992#comment-14157992 ]

Gary Gregory commented on LOG4J2-867:
-------------------------------------

We should do a pass (before 2.1 or after?) where all ivars and params in the code include a scale like maxDelayMillis instead of maxDelay.

For file configs, I think we should add a scale version of a setting and deprecate any unscaled name. It's a recipe for confusion otherwise.

Gary

Post by Simon Broeng Jensen (JIRA)
FlumeAppender: maxDelay not in seconds, but milliseconds
--------------------------------------------------------
Key: LOG4J2-867
URL: https://issues.apache.org/jira/browse/LOG4J2-867
Project: Log4j 2
Issue Type: Documentation
Components: Appenders
Affects Versions: 2.0.2
Reporter: Simon Broeng Jensen
Priority: Minor
Hi,
We are using FlumeAppender with Log4j2, version 2.0.2.
The documentation, and javadoc, specifies maxDelay as using seconds, but it's actually used as milliseconds (see FlumePersistentManager).
https://logging.apache.org/log4j/2.x/manual/appenders.html#FlumeAppender

--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Gary Gregory (JIRA)

2014-10-03 22:37:34 UTC

Permalink

[ https://issues.apache.org/jira/browse/LOG4J2-867?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14158619#comment-14158619 ]

Gary Gregory commented on LOG4J2-867:
-------------------------------------

First step: I've updated the code to use a Millis postfix for ivars and pnames, so have delay -> delayMillis.

--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Gary Gregory (JIRA)

2014-10-03 22:49:33 UTC

Permalink

[ https://issues.apache.org/jira/browse/LOG4J2-867?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Gary Gregory resolved LOG4J2-867.
---------------------------------
Resolution: Fixed
Fix Version/s: 2.1

Fix pushed to master.

Please verify and close.

Post by Simon Broeng Jensen (JIRA)
FlumeAppender: maxDelay not in seconds, but milliseconds
--------------------------------------------------------
Key: LOG4J2-867
URL: https://issues.apache.org/jira/browse/LOG4J2-867
Project: Log4j 2
Issue Type: Documentation
Components: Appenders
Affects Versions: 2.0.2
Reporter: Simon Broeng Jensen
Priority: Minor
Fix For: 2.1
Hi,
We are using FlumeAppender with Log4j2, version 2.0.2.
The documentation, and javadoc, specifies maxDelay as using seconds, but it's actually used as milliseconds (see FlumePersistentManager).
https://logging.apache.org/log4j/2.x/manual/appenders.html#FlumeAppender

--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Gary Gregory (JIRA)

2014-10-04 04:26:34 UTC

Permalink

[ https://issues.apache.org/jira/browse/LOG4J2-867?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14158938#comment-14158938 ]

Gary Gregory commented on LOG4J2-867:
-------------------------------------

Recap:

- Add time scale to some settings, for example maxDelayMillis instead of maxDelay.
- The old names are aliased for compatibility.

Post by Simon Broeng Jensen (JIRA)
FlumeAppender: maxDelay not in seconds, but milliseconds
--------------------------------------------------------
Key: LOG4J2-867
URL: https://issues.apache.org/jira/browse/LOG4J2-867
Project: Log4j 2
Issue Type: Documentation
Components: Appenders
Affects Versions: 2.0.2
Reporter: Simon Broeng Jensen
Priority: Minor
Fix For: 2.1
Hi,
We are using FlumeAppender with Log4j2, version 2.0.2.
The documentation, and javadoc, specifies maxDelay as using seconds, but it's actually used as milliseconds (see FlumePersistentManager).
https://logging.apache.org/log4j/2.x/manual/appenders.html#FlumeAppender

--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Simon Broeng Jensen (JIRA)

2014-10-13 10:00:34 UTC

Permalink

[ https://issues.apache.org/jira/browse/LOG4J2-867?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14169150#comment-14169150 ]

Simon Broeng Jensen commented on LOG4J2-867:
--------------------------------------------

Sorry about the late reply on my part.

I have reviewed the related commits, and it looks good. I only noticed a minor documentation issue on the FailoverAppender, the javadoc for retryIntervalSeconds is still using the intervalMillis description.

Diff:
{code}
- * @param retryIntervalString The retry intervalMillis.
+ * @param retryIntervalSeconds The retry intervalMillis.
{code}

From:

https://git-wip-us.apache.org/repos/asf?p=logging-log4j2.git;a=blobdiff;f=log4j-core/src/main/java/org/apache/logging/log4j/core/appender/FailoverAppender.java;h=9629a2935d11940e0a368a8a3aa5668f7c5d6dca;hp=c46096461c53cbe154876fefef9f2e4ab3841ada;hb=f6bd93ce9a25313164d1ef2634fdbfb8a9200a27;hpb=b46ee74349f796bb0297dbc0527de9a7c6d6e0d0

I'm assuming the documentation for maxDelay (https://logging.apache.org/log4j/2.x/manual/appenders.html#FlumeAppender) will be updated with the next release.

Should I close the issue?

Post by Simon Broeng Jensen (JIRA)
FlumeAppender: maxDelay not in seconds, but milliseconds
--------------------------------------------------------
Key: LOG4J2-867
URL: https://issues.apache.org/jira/browse/LOG4J2-867
Project: Log4j 2
Issue Type: Documentation
Components: Appenders
Affects Versions: 2.0.2
Reporter: Simon Broeng Jensen
Priority: Minor
Fix For: 2.1
Hi,
We are using FlumeAppender with Log4j2, version 2.0.2.
The documentation, and javadoc, specifies maxDelay as using seconds, but it's actually used as milliseconds (see FlumePersistentManager).
https://logging.apache.org/log4j/2.x/manual/appenders.html#FlumeAppender

--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Gary Gregory (JIRA)

2014-10-13 12:34:33 UTC

Permalink

[ https://issues.apache.org/jira/browse/LOG4J2-867?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14169230#comment-14169230 ]

Gary Gregory commented on LOG4J2-867:
-------------------------------------

Thank you for your feedback.

The code and docs should be up to date in master.

Post by Simon Broeng Jensen (JIRA)
FlumeAppender: maxDelay not in seconds, but milliseconds
--------------------------------------------------------
Key: LOG4J2-867
URL: https://issues.apache.org/jira/browse/LOG4J2-867
Project: Log4j 2
Issue Type: Documentation
Components: Appenders
Affects Versions: 2.0.2
Reporter: Simon Broeng Jensen
Priority: Minor
Fix For: 2.1
Hi,
We are using FlumeAppender with Log4j2, version 2.0.2.
The documentation, and javadoc, specifies maxDelay as using seconds, but it's actually used as milliseconds (see FlumePersistentManager).
https://logging.apache.org/log4j/2.x/manual/appenders.html#FlumeAppender

--
This message was sent by Atlassian JIRA
(v6.3.4#6332)