[2/2] git commit: Javadoc: Replace @doubt with TODO tags. Custom @'s in Javadoc 8 are not allowed unpackaged and then must exist, and we do not have them, so just use a "TODO" tag which can then be picked up with the Maven tag report if we want to add th

[Remko Popma]

I'm getting a compile error:

Interpolator now has this line:
+ lookups.put("java", new JavaLookup());
But the JavaLookup class does not exist...


Sent from my iPhone

+ lookups.put("java", new JavaLookup());

[Gary Gregory]

Arg, I was not supposed to commit that file. Will fix asap.

Gary

<div>-------- Original message --------</div><div>From: Remko Popma <***@gmail.com> </div><div>Date:09/22/2014 05:29 (GMT-05:00) </div><div>To: Developers List Log4J <log4j-***@logging.apache.org> </div><div>Subject: Re: [2/2] git commit: Javadoc: Replace @doubt with TODO tags. Custom @'s in Javadoc 8 are not allowed unpackaged and then must exist, and we do not have them, so just use a "TODO" tag which can then be picked up with the Maven tag report if we want to add th </div><div>
</div>I'm getting a compile error:

Interpolator now has this line:
+ lookups.put("java", new JavaLookup());
But the JavaLookup class does not exist...


Sent from my iPhone

Post by Remko Popma
+ lookups.put("java", new JavaLookup());

---------------------------------------------------------------------
To unsubscribe, e-mail: log4j-dev-***@logging.apache.org
For additional commands, e-mail: log4j-dev-***@logging.apache.org

[Ralph Goers]

I thought Gary recently implemented that.

Please read the @doubts. I imagine most of them can be removed at this point.

Ralph

Post by Remko Popma
+ lookups.put("java", new JavaLookup());
But the JavaLookup class does not exist...
Sent from my iPhone

Post by Remko Popma
+ lookups.put("java", new JavaLookup());

---------------------------------------------------------------------

[Gary Gregory]

Post by Ralph Goers
I thought Gary recently implemented that.

I had talked about it, and worked it out over the weekend, it's not much
code actually (as expected).

What was unexpected is that while lookups work in header and footers, %'s
do not, so you cannot use formatted dates, end-of-lines and such.

Gary

Post by Ralph Goers
Ralph

Post by Remko Popma
+ lookups.put("java", new JavaLookup());
But the JavaLookup class does not exist...
Sent from my iPhone

Post by Remko Popma
+ lookups.put("java", new JavaLookup());

---------------------------------------------------------------------

---------------------------------------------------------------------

[Ralph Goers]

What do you mean “%’s do not”? You mean PatternConverters? I think someone asked for that enhancement, but since the header and footer are processed before a LogEvent exists their are a whole pile of them that won’t work.

Ralph

Post by Ralph Goers
I thought Gary recently implemented that.
I had talked about it, and worked it out over the weekend, it's not much code actually (as expected).
What was unexpected is that while lookups work in header and footers, %'s do not, so you cannot use formatted dates, end-of-lines and such.
Gary
Ralph

Post by Remko Popma
+ lookups.put("java", new JavaLookup());
But the JavaLookup class does not exist...
Sent from my iPhone

Post by Remko Popma
+ lookups.put("java", new JavaLookup());

---------------------------------------------------------------------

---------------------------------------------------------------------
--
Java Persistence with Hibernate, Second Edition
JUnit in Action, Second Edition
Spring Batch in Action
Blog: http://garygregory.wordpress.com
Home: http://garygregory.com/
Tweet! http://twitter.com/GaryGregory

[Gary Gregory]

I mean that I cannot get values for "%n" and "%d{UNIX}" in a header or
footer.

I was trying to use %n and it did not work so I tried %d{UNIX} just to see
what would happen and it did not work either.

Looking at the code, this is not surprising since the enhancement
implemented in LOG4J-496 only covered look-ups.

For my narrow case, the workaround is the more verbose
${sys:line.separator}, which is a system property look-up.

I created https://issues.apache.org/jira/browse/LOG4J2-847

Gary

What do you mean “%’s do not”? You mean PatternConverters? I think
someone asked for that enhancement, but since the header and footer are
processed before a LogEvent exists their are a whole pile of them that
won’t work.
Ralph

Post by Ralph Goers
I thought Gary recently implemented that.

I had talked about it, and worked it out over the weekend, it's not much
code actually (as expected).
What was unexpected is that while lookups work in header and footers, %'s
do not, so you cannot use formatted dates, end-of-lines and such.
Gary

Post by Ralph Goers
Ralph

Post by Remko Popma
+ lookups.put("java", new JavaLookup());
But the JavaLookup class does not exist...
Sent from my iPhone

Post by Remko Popma
+ lookups.put("java", new JavaLookup());

---------------------------------------------------------------------

---------------------------------------------------------------------

--
Java Persistence with Hibernate, Second Edition
<http://www.manning.com/bauer3/>
JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
Spring Batch in Action <http://www.manning.com/templier/>
Blog: http://garygregory.wordpress.com
Home: http://garygregory.com/
Tweet! http://twitter.com/GaryGregory