Discussion:
Build fails - serialization
Remko Popma
2014-09-09 06:41:23 UTC
Permalink
DynamicalThresholdFilter does not implement equals(), so the AbstractSerializationTest.testSerializationRoundtrip fails.

Sent from my iPhone
Gary Gregory
2014-09-09 13:06:00 UTC
Permalink
My bad, sorry :-( Fixed in git master.

Gary
Post by Remko Popma
DynamicalThresholdFilter does not implement equals(), so the
AbstractSerializationTest.testSerializationRoundtrip fails.
Sent from my iPhone
---------------------------------------------------------------------
--
E-Mail: ***@gmail.com | ***@apache.org
Java Persistence with Hibernate, Second Edition
<http://www.manning.com/bauer3/>
JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
Spring Batch in Action <http://www.manning.com/templier/>
Blog: http://garygregory.wordpress.com
Home: http://garygregory.com/
Tweet! http://twitter.com/GaryGregory
Remko Popma
2014-09-09 15:12:30 UTC
Permalink
No problem!
I looked at the commit emails, but I couldn't see if an equals() method was added to DynamicThresholdFilter. Without that method, the default Object.equals will fail the assert because the serialized-deserialized filter is a different instance from the original filter. Does the test work? (I may have missed something...)

Sent from my iPhone
Post by Gary Gregory
My bad, sorry :-( Fixed in git master.
Gary
Post by Remko Popma
DynamicalThresholdFilter does not implement equals(), so the AbstractSerializationTest.testSerializationRoundtrip fails.
Sent from my iPhone
---------------------------------------------------------------------
--
Java Persistence with Hibernate, Second Edition
JUnit in Action, Second Edition
Spring Batch in Action
Blog: http://garygregory.wordpress.com
Home: http://garygregory.com/
Tweet! http://twitter.com/GaryGregory
Remko Popma
2014-09-09 15:15:34 UTC
Permalink
Ah! I overlooked an email, now I see it. Please ignore my previous message.
Post by Remko Popma
No problem!
I looked at the commit emails, but I couldn't see if an equals() method
was added to DynamicThresholdFilter. Without that method, the default
Object.equals will fail the assert because the serialized-deserialized
filter is a different instance from the original filter. Does the test
work? (I may have missed something...)
Sent from my iPhone
My bad, sorry :-( Fixed in git master.
Gary
Post by Remko Popma
DynamicalThresholdFilter does not implement equals(), so the
AbstractSerializationTest.testSerializationRoundtrip fails.
Sent from my iPhone
---------------------------------------------------------------------
--
Java Persistence with Hibernate, Second Edition
<http://www.manning.com/bauer3/>
JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
Spring Batch in Action <http://www.manning.com/templier/>
Blog: http://garygregory.wordpress.com
Home: http://garygregory.com/
Tweet! http://twitter.com/GaryGregory
Loading...