Discussion:
logback in POMs
Gary Gregory
2014-10-04 02:16:20 UTC
Permalink
Hi All:

Shouldn't all the logback references in POMs be in the test scope?

Gary
--
E-Mail: ***@gmail.com | ***@apache.org
Java Persistence with Hibernate, Second Edition
<http://www.manning.com/bauer3/>
JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
Spring Batch in Action <http://www.manning.com/templier/>
Blog: http://garygregory.wordpress.com
Home: http://garygregory.com/
Tweet! http://twitter.com/GaryGregory
Matt Sicker
2014-10-04 05:11:00 UTC
Permalink
That would make sense indeed.
Post by Gary Gregory
Shouldn't all the logback references in POMs be in the test scope?
Gary
--
Java Persistence with Hibernate, Second Edition
<http://www.manning.com/bauer3/>
JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
Spring Batch in Action <http://www.manning.com/templier/>
Blog: http://garygregory.wordpress.com
Home: http://garygregory.com/
Tweet! http://twitter.com/GaryGregory
--
Matt Sicker <***@gmail.com>
Remko Popma
2014-10-04 12:47:49 UTC
Permalink
The perf module doesn't have unit tests, all benchmarks are in main. Some benchmarks test logback, so that's ok to remain as a main dependency.

Sent from my iPhone
Done. Just one change. The perf module is a "main" dep.
Gary
Post by Matt Sicker
That would make sense indeed.
Post by Gary Gregory
Shouldn't all the logback references in POMs be in the test scope?
Gary
--
Java Persistence with Hibernate, Second Edition
JUnit in Action, Second Edition
Spring Batch in Action
Blog: http://garygregory.wordpress.com
Home: http://garygregory.com/
Tweet! http://twitter.com/GaryGregory
--
--
Java Persistence with Hibernate, Second Edition
JUnit in Action, Second Edition
Spring Batch in Action
Blog: http://garygregory.wordpress.com
Home: http://garygregory.com/
Tweet! http://twitter.com/GaryGregory
Matt Sicker
2014-10-04 16:25:11 UTC
Permalink
Remko, I fixed that in my local branch. I'll push that today before I
officially start the release process.
Post by Remko Popma
The perf module doesn't have unit tests, all benchmarks are in main. Some
benchmarks test logback, so that's ok to remain as a main dependency.
Sent from my iPhone
Done. Just one change. The perf module is a "main" dep.
Gary
Post by Matt Sicker
That would make sense indeed.
Post by Gary Gregory
Shouldn't all the logback references in POMs be in the test scope?
Gary
--
Java Persistence with Hibernate, Second Edition
<http://www.manning.com/bauer3/>
JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
Spring Batch in Action <http://www.manning.com/templier/>
Blog: http://garygregory.wordpress.com
Home: http://garygregory.com/
Tweet! http://twitter.com/GaryGregory
--
--
Java Persistence with Hibernate, Second Edition
<http://www.manning.com/bauer3/>
JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
Spring Batch in Action <http://www.manning.com/templier/>
Blog: http://garygregory.wordpress.com
Home: http://garygregory.com/
Tweet! http://twitter.com/GaryGregory
--
Matt Sicker <***@gmail.com>
Gary Gregory
2014-10-04 12:18:11 UTC
Permalink
Done. Just one change. The perf module is a "main" dep.

Gary
Post by Matt Sicker
That would make sense indeed.
Post by Gary Gregory
Shouldn't all the logback references in POMs be in the test scope?
Gary
--
Java Persistence with Hibernate, Second Edition
<http://www.manning.com/bauer3/>
JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
Spring Batch in Action <http://www.manning.com/templier/>
Blog: http://garygregory.wordpress.com
Home: http://garygregory.com/
Tweet! http://twitter.com/GaryGregory
--
--
E-Mail: ***@gmail.com | ***@apache.org
Java Persistence with Hibernate, Second Edition
<http://www.manning.com/bauer3/>
JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
Spring Batch in Action <http://www.manning.com/templier/>
Blog: http://garygregory.wordpress.com
Home: http://garygregory.com/
Tweet! http://twitter.com/GaryGregory
Loading...