[2/5] git commit: Add license header.

Discussion:

Gary Gregory

2014-09-25 10:43:08 UTC

How about making the build fail if a header is missing?

Gary

<div>-------- Original message --------</div><div>From: ***@apache.org </div><div>Date:09/25/2014 00:03 (GMT-05:00) </div><div>To: ***@logging.apache.org </div><div>Subject: [2/5] git commit: Add license header. </div><div>
</div>Add license header.

Project: http://git-wip-us.apache.org/repos/asf/logging-log4j2/repo
Commit: http://git-wip-us.apache.org/repos/asf/logging-log4j2/commit/268d9df4
Tree: http://git-wip-us.apache.org/repos/asf/logging-log4j2/tree/268d9df4
Diff: http://git-wip-us.apache.org/repos/asf/logging-log4j2/diff/268d9df4

Branch: refs/heads/master
Commit: 268d9df487fb7249e940f1a9b641e179c9bd97fe
Parents: 310e0c4
Author: Matt Sicker <***@apache.org>
Authored: Wed Sep 24 22:18:05 2014 -0500
Committer: Matt Sicker <***@apache.org>
Committed: Wed Sep 24 23:03:31 2014 -0500

----------------------------------------------------------------------
.../org/apache/logging/log4j/spi/LoggerAdapter.java | 16 ++++++++++++++++
1 file changed, 16 insertions(+)
----------------------------------------------------------------------

http://git-wip-us.apache.org/repos/asf/logging-log4j2/blob/268d9df4/log4j-api/src/main/java/org/apache/logging/log4j/spi/LoggerAdapter.java
----------------------------------------------------------------------
diff --git a/log4j-api/src/main/java/org/apache/logging/log4j/spi/LoggerAdapter.java b/log4j-api/src/main/java/org/apache/logging/log4j/spi/LoggerAdapter.java
index 26f2dcf..6bac9bd 100644
--- a/log4j-api/src/main/java/org/apache/logging/log4j/spi/LoggerAdapter.java
+++ b/log4j-api/src/main/java/org/apache/logging/log4j/spi/LoggerAdapter.java
@@ -1,3 +1,19 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache license, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the license for the specific language governing permissions and
+ * limitations under the license.
+ */
package org.apache.logging.log4j.spi;

import java.io.Closeable;

Matt Sicker

2014-09-25 13:59:04 UTC

Permalink

Not a bad idea. I noticed this from doing a site build in the rat report.

Post by Gary Gregory
How about making the build fail if a header is missing?
Gary
-------- Original message --------
Date:09/25/2014 00:03 (GMT-05:00)
Subject: [2/5] git commit: Add license header.
Add license header.
Project: http://git-wip-us.apache.org/repos/asf/logging-log4j2/repo
http://git-wip-us.apache.org/repos/asf/logging-log4j2/commit/268d9df4
Tree: http://git-wip-us.apache.org/repos/asf/logging-log4j2/tree/268d9df4
Diff: http://git-wip-us.apache.org/repos/asf/logging-log4j2/diff/268d9df4
Branch: refs/heads/master
Commit: 268d9df487fb7249e940f1a9b641e179c9bd97fe
Parents: 310e0c4
Authored: Wed Sep 24 22:18:05 2014 -0500
Committed: Wed Sep 24 23:03:31 2014 -0500
----------------------------------------------------------------------
.../org/apache/logging/log4j/spi/LoggerAdapter.java | 16 ++++++++++++++++
1 file changed, 16 insertions(+)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/logging-log4j2/blob/268d9df4/log4j-api/src/main/java/org/apache/logging/log4j/spi/LoggerAdapter.java
----------------------------------------------------------------------
diff --git
a/log4j-api/src/main/java/org/apache/logging/log4j/spi/LoggerAdapter.java
b/log4j-api/src/main/java/org/apache/logging/log4j/spi/LoggerAdapter.java
index 26f2dcf..6bac9bd 100644
---
a/log4j-api/src/main/java/org/apache/logging/log4j/spi/LoggerAdapter.java
+++
b/log4j-api/src/main/java/org/apache/logging/log4j/spi/LoggerAdapter.java
@@ -1,3 +1,19 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache license, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the license for the specific language governing permissions and
+ * limitations under the license.
+ */
package org.apache.logging.log4j.spi;
import java.io.Closeable;

--
Matt Sicker <***@gmail.com>

Ralph Goers

2014-09-25 15:13:57 UTC

Permalink

The release manager should be running the rat report before they even start the build. From my experience, this is the most common error that will fail a release.

Ralph

Post by Matt Sicker
Not a bad idea. I noticed this from doing a site build in the rat report.
How about making the build fail if a header is missing?
Gary
-------- Original message --------
Date:09/25/2014 00:03 (GMT-05:00)
Subject: [2/5] git commit: Add license header.
Add license header.
Project: http://git-wip-us.apache.org/repos/asf/logging-log4j2/repo
Commit: http://git-wip-us.apache.org/repos/asf/logging-log4j2/commit/268d9df4
Tree: http://git-wip-us.apache.org/repos/asf/logging-log4j2/tree/268d9df4
Diff: http://git-wip-us.apache.org/repos/asf/logging-log4j2/diff/268d9df4
Branch: refs/heads/master
Commit: 268d9df487fb7249e940f1a9b641e179c9bd97fe
Parents: 310e0c4
Authored: Wed Sep 24 22:18:05 2014 -0500
Committed: Wed Sep 24 23:03:31 2014 -0500
----------------------------------------------------------------------
.../org/apache/logging/log4j/spi/LoggerAdapter.java | 16 ++++++++++++++++
1 file changed, 16 insertions(+)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/logging-log4j2/blob/268d9df4/log4j-api/src/main/java/org/apache/logging/log4j/spi/LoggerAdapter.java
----------------------------------------------------------------------
diff --git a/log4j-api/src/main/java/org/apache/logging/log4j/spi/LoggerAdapter.java b/log4j-api/src/main/java/org/apache/logging/log4j/spi/LoggerAdapter.java
index 26f2dcf..6bac9bd 100644
--- a/log4j-api/src/main/java/org/apache/logging/log4j/spi/LoggerAdapter.java
+++ b/log4j-api/src/main/java/org/apache/logging/log4j/spi/LoggerAdapter.java
@@ -1,3 +1,19 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache license, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the license for the specific language governing permissions and
+ * limitations under the license.
+ */
package org.apache.logging.log4j.spi;
import java.io.Closeable;
--

Matt Sicker

2014-09-25 17:50:22 UTC

Permalink

Well it's a good thing I started testing out the release build parts before
doing it for real then! I'm working on any improvements I can figure out
with the javadocs.

Post by Ralph Goers
The release manager should be running the rat report before they even
start the build. From my experience, this is the most common error that
will fail a release.
Ralph
Not a bad idea. I noticed this from doing a site build in the rat report.

--
Matt Sicker <***@gmail.com>

Gary Gregory

2014-09-27 12:41:30 UTC

Permalink

Here is how to run the RAT plugin when you build:

https://creadur.apache.org/rat/apache-rat-plugin/examples/verify.html

Gary

Post by Matt Sicker
Well it's a good thing I started testing out the release build parts
before doing it for real then! I'm working on any improvements I can figure
out with the javadocs.

Post by Gary Gregory
How about making the build fail if a header is missing?
Gary
-------- Original message --------
Date:09/25/2014 00:03 (GMT-05:00)
Subject: [2/5] git commit: Add license header.
Add license header.
Project: http://git-wip-us.apache.org/repos/asf/logging-log4j2/repo
http://git-wip-us.apache.org/repos/asf/logging-log4j2/commit/268d9df4
http://git-wip-us.apache.org/repos/asf/logging-log4j2/tree/268d9df4
http://git-wip-us.apache.org/repos/asf/logging-log4j2/diff/268d9df4
Branch: refs/heads/master
Commit: 268d9df487fb7249e940f1a9b641e179c9bd97fe
Parents: 310e0c4
Authored: Wed Sep 24 22:18:05 2014 -0500
Committed: Wed Sep 24 23:03:31 2014 -0500
----------------------------------------------------------------------
.../org/apache/logging/log4j/spi/LoggerAdapter.java | 16 ++++++++++++++++
1 file changed, 16 insertions(+)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/logging-log4j2/blob/268d9df4/log4j-api/src/main/java/org/apache/logging/log4j/spi/LoggerAdapter.java
----------------------------------------------------------------------
diff --git
a/log4j-api/src/main/java/org/apache/logging/log4j/spi/LoggerAdapter.java
b/log4j-api/src/main/java/org/apache/logging/log4j/spi/LoggerAdapter.java
index 26f2dcf..6bac9bd 100644
---
a/log4j-api/src/main/java/org/apache/logging/log4j/spi/LoggerAdapter.java
+++
b/log4j-api/src/main/java/org/apache/logging/log4j/spi/LoggerAdapter.java
@@ -1,3 +1,19 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache license, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the license for the specific language governing permissions and
+ * limitations under the license.
+ */
package org.apache.logging.log4j.spi;
import java.io.Closeable;

--
E-Mail: ***@gmail.com | ***@apache.org
Java Persistence with Hibernate, Second Edition
<http://www.manning.com/bauer3/>
JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
Spring Batch in Action <http://www.manning.com/templier/>
Blog: http://garygregory.wordpress.com
Home: http://garygregory.com/
Tweet! http://twitter.com/GaryGregory